From: Saranya Gopal Date: Wed, 20 Oct 2021 02:26:19 +0000 (+0530) Subject: usb: typec: tipd: Enable event interrupts by default X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9990f2f6264cd19cb6ba12d9f9c1c30ae8351096;p=linux.git usb: typec: tipd: Enable event interrupts by default TI PD controller comes with notification mechanism to inform the host on activity in the PD controller. In the current driver, the required masks are not set. This patch enables the following events in the interrupt mask register: PowerStatusUpdate - Set whenever contents of the power status reg changes DataStatusUpdate - Set whenever contents of the data status reg changes PlugInsertOrRemoval - Set whenever USB plug status has changed With this change, the interrupt flooding issue is not seen anymore. Suggested-by: Rajaram Regupathy Reviewed-by: Andy Shevchenko Reviewed-by: Heikki Krogerus Acked-by: Hans de Goede Signed-off-by: Saranya Gopal Datasheet: https://www.ti.com/lit/ug/slvuan1a/slvuan1a.pdf Link: https://lore.kernel.org/r/20211020022620.21012-2-saranya.gopal@intel.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/typec/tipd/core.c b/drivers/usb/typec/tipd/core.c index 97311a45f666a..fb8ef12bbe9c8 100644 --- a/drivers/usb/typec/tipd/core.c +++ b/drivers/usb/typec/tipd/core.c @@ -750,6 +750,14 @@ static int tps6598x_probe(struct i2c_client *client) return ret; irq_handler = cd321x_interrupt; + } else { + /* Enable power status, data status and plug event interrupts */ + ret = tps6598x_write64(tps, TPS_REG_INT_MASK1, + TPS_REG_INT_POWER_STATUS_UPDATE | + TPS_REG_INT_DATA_STATUS_UPDATE | + TPS_REG_INT_PLUG_EVENT); + if (ret) + return ret; } ret = tps6598x_read32(tps, TPS_REG_STATUS, &status);