From: David Woodhouse <dwmw@amazon.co.uk>
Date: Mon, 8 Feb 2021 23:23:26 +0000 (+0000)
Subject: KVM: x86/xen: Remove extra unlock in kvm_xen_hvm_set_attr()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=99df541dcc97ce4436528a4eeb23165d8c672a64;p=linux.git

KVM: x86/xen: Remove extra unlock in kvm_xen_hvm_set_attr()

This accidentally ended up locking and then immediately unlocking kvm->lock
at the beginning of the function. Fix it.

Fixes: a76b9641ad1c ("KVM: x86/xen: add KVM_XEN_HVM_SET_ATTR/KVM_XEN_HVM_GET_ATTR")
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Message-Id: <20210208232326.1830370-2-dwmw2@infradead.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/arch/x86/kvm/xen.c b/arch/x86/kvm/xen.c
index 39a7ffcdcf228..54a4895d4440d 100644
--- a/arch/x86/kvm/xen.c
+++ b/arch/x86/kvm/xen.c
@@ -105,8 +105,6 @@ int kvm_xen_hvm_set_attr(struct kvm *kvm, struct kvm_xen_hvm_attr *data)
 
 	mutex_lock(&kvm->lock);
 
-	mutex_unlock(&kvm->lock);
-
 	switch (data->type) {
 	case KVM_XEN_ATTR_TYPE_LONG_MODE:
 		if (!IS_ENABLED(CONFIG_64BIT) && data->u.long_mode) {