From: Li Heng <liheng40@huawei.com>
Date: Thu, 23 Jul 2020 03:15:16 +0000 (+0800)
Subject: um: Remove redundant NULL check
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9a10705b42dd541feadda4817582a7efc984c917;p=linux.git

um: Remove redundant NULL check

Fix below warnings reported by coccicheck:
./arch/um/drivers/vector_user.c:403:2-7: WARNING: NULL check before some freeing functions is not needed.

Fixes: bc8f8e4e6e7a ("um: Add a generic "fd" vector transport")
Signed-off-by: Li Heng <liheng40@huawei.com>
Signed-off-by: Richard Weinberger <richard@nod.at>
---

diff --git a/arch/um/drivers/vector_user.c b/arch/um/drivers/vector_user.c
index 090ff93457c78..65b6a71a132fe 100644
--- a/arch/um/drivers/vector_user.c
+++ b/arch/um/drivers/vector_user.c
@@ -397,8 +397,7 @@ static struct vector_fds *user_init_fd_fds(struct arglist *ifspec)
 fd_cleanup:
 	if (fd >= 0)
 		os_close_file(fd);
-	if (result != NULL)
-		kfree(result);
+	kfree(result);
 	return NULL;
 }