From: Martin Kaiser <martin@kaiser.cx>
Date: Mon, 5 Sep 2022 20:01:44 +0000 (+0200)
Subject: staging: r8188eu: always cancel blink_work when WPS failed
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9b34e23b1fff0d70a9939c5a29aa3c629716c305;p=linux.git

staging: r8188eu: always cancel blink_work when WPS failed

Cancel blink_work if WPS fails. Another worker will be scheduled after
the state variables are updated.

Tested-by: Michael Straube <straube.linux@gmail.com>
Signed-off-by: Martin Kaiser <martin@kaiser.cx>
Link: https://lore.kernel.org/r/20220905200146.82259-6-martin@kaiser.cx
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/staging/r8188eu/core/rtw_led.c b/drivers/staging/r8188eu/core/rtw_led.c
index 4841bb2898ba7..80d9d8184fcd0 100644
--- a/drivers/staging/r8188eu/core/rtw_led.c
+++ b/drivers/staging/r8188eu/core/rtw_led.c
@@ -357,8 +357,8 @@ void rtw_led_control(struct adapter *padapter, enum LED_CTL_MODE LedAction)
 		}
 		break;
 	case LED_CTL_STOP_WPS_FAIL:
+		cancel_delayed_work(&pLed->blink_work);
 		if (pLed->bLedWPSBlinkInProgress) {
-			cancel_delayed_work(&pLed->blink_work);
 			pLed->bLedWPSBlinkInProgress = false;
 		}
 		pLed->bLedNoLinkBlinkInProgress = true;