From: Jiri Slaby Date: Tue, 3 May 2022 08:08:05 +0000 (+0200) Subject: serial: pch: remove debug print from pop_tx X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9bc995f51d7828bec9b7432f0034b6e31cefb851;p=linux.git serial: pch: remove debug print from pop_tx It makes the code overly complicated for no good reason. Signed-off-by: Jiri Slaby Link: https://lore.kernel.org/r/20220503080808.28332-3-jslaby@suse.cz Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/serial/pch_uart.c b/drivers/tty/serial/pch_uart.c index 4fcb6c144b548..a90bdff609089 100644 --- a/drivers/tty/serial/pch_uart.c +++ b/drivers/tty/serial/pch_uart.c @@ -764,7 +764,7 @@ static bool pop_tx(struct eg20t_port *priv, unsigned int size) struct circ_buf *xmit = &port->state->xmit; if (uart_tx_stopped(port)) - goto pop_tx_end; + return false; while (!uart_circ_empty(xmit) && count < size) { iowrite8(xmit->buf[xmit->tail], priv->membase + PCH_UART_THR); @@ -773,10 +773,6 @@ static bool pop_tx(struct eg20t_port *priv, unsigned int size) count++; } -pop_tx_end: - dev_dbg(priv->port.dev, "%d characters. Remained %d characters.(%lu)\n", - count, size - count, jiffies); - return count; }