From: Ard Biesheuvel Date: Sat, 24 Feb 2024 17:45:41 +0000 (+0100) Subject: efivarfs: Drop redundant cleanup on fill_super() failure X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9ca01c7adf3993044f59934082087ebb9f7df6d5;p=linux.git efivarfs: Drop redundant cleanup on fill_super() failure Al points out that kill_sb() will be called if efivarfs_fill_super() fails and so there is no point in cleaning up the efivar entry list. Reported-by: Alexander Viro Signed-off-by: Ard Biesheuvel --- diff --git a/fs/efivarfs/super.c b/fs/efivarfs/super.c index 6038dd39367ab..210daac79748f 100644 --- a/fs/efivarfs/super.c +++ b/fs/efivarfs/super.c @@ -343,12 +343,7 @@ static int efivarfs_fill_super(struct super_block *sb, struct fs_context *fc) if (err) return err; - err = efivar_init(efivarfs_callback, (void *)sb, true, - &sfi->efivarfs_list); - if (err) - efivar_entry_iter(efivarfs_destroy, &sfi->efivarfs_list, NULL); - - return err; + return efivar_init(efivarfs_callback, sb, true, &sfi->efivarfs_list); } static int efivarfs_get_tree(struct fs_context *fc)