From: Miaoqian Lin <linmq006@gmail.com>
Date: Wed, 20 Apr 2022 11:04:08 +0000 (+0800)
Subject: net: dsa: Add missing of_node_put() in dsa_port_link_register_of
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9cc897ca03df52a2fec8632b40d45862fa75d69e;p=linux.git

net: dsa: Add missing of_node_put() in dsa_port_link_register_of

[ Upstream commit fc06b2867f4cea543505acfb194c2be4ebf0c7d3 ]

The device_node pointer is returned by of_parse_phandle()  with refcount
incremented. We should use of_node_put() on it when done.
of_node_put() will check for NULL value.

Fixes: a20f997010c4 ("net: dsa: Don't instantiate phylink for CPU/DSA ports unless needed")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
---

diff --git a/net/dsa/port.c b/net/dsa/port.c
index 616330a16d319..63e88de963936 100644
--- a/net/dsa/port.c
+++ b/net/dsa/port.c
@@ -1201,8 +1201,10 @@ int dsa_port_link_register_of(struct dsa_port *dp)
 			if (ds->ops->phylink_mac_link_down)
 				ds->ops->phylink_mac_link_down(ds, port,
 					MLO_AN_FIXED, PHY_INTERFACE_MODE_NA);
+			of_node_put(phy_np);
 			return dsa_port_phylink_register(dp);
 		}
+		of_node_put(phy_np);
 		return 0;
 	}