From: Marc Kleine-Budde Date: Tue, 31 Jan 2023 16:37:39 +0000 (+0100) Subject: can: bittiming: can_fixup_bittiming(): use CAN_SYNC_SEG instead of 1 X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9cf670dbe69d11c6f29284aa80d78741f038ecd4;p=linux.git can: bittiming: can_fixup_bittiming(): use CAN_SYNC_SEG instead of 1 Commit 1c47fa6b31c2 ("can: dev: add a helper function to calculate the duration of one bit") made the constant CAN_SYNC_SEG available in a header file. The magic number 1 in can_fixup_bittiming() represents the width of the sync segment, replace it by CAN_SYNC_SEG to make the code more readable. Link: https://lore.kernel.org/all/20230202110854.2318594-3-mkl@pengutronix.de Signed-off-by: Marc Kleine-Budde --- diff --git a/drivers/net/can/dev/bittiming.c b/drivers/net/can/dev/bittiming.c index 32af609eee504..5e111dbbe090b 100644 --- a/drivers/net/can/dev/bittiming.c +++ b/drivers/net/can/dev/bittiming.c @@ -39,7 +39,7 @@ static int can_fixup_bittiming(const struct net_device *dev, struct can_bittimin return -EINVAL; bt->bitrate = priv->clock.freq / (bt->brp * can_bit_time(bt)); - bt->sample_point = ((tseg1 + 1) * 1000) / can_bit_time(bt); + bt->sample_point = ((CAN_SYNC_SEG + tseg1) * 1000) / can_bit_time(bt); return 0; }