From: Li Nan <linan122@huawei.com>
Date: Mon, 26 Feb 2024 03:14:38 +0000 (+0800)
Subject: md: clean up invalid BUG_ON in md_ioctl
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9dd8702e7cd28ebf076ff838933f29cf671165ec;p=linux.git

md: clean up invalid BUG_ON in md_ioctl

'disk->private_data' is set to mddev in md_alloc() and never set to NULL,
and users need to open mddev before submitting ioctl. So mddev must not
have been freed during ioctl, and there is no need to check mddev here.
Clean up it.

Signed-off-by: Li Nan <linan122@huawei.com>
Reviewed-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20240226031444.3606764-4-linan666@huaweicloud.com
---

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 3c8a0784cf6ac..08170902d3424 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -7622,11 +7622,6 @@ static int md_ioctl(struct block_device *bdev, blk_mode_t mode,
 
 	mddev = bdev->bd_disk->private_data;
 
-	if (!mddev) {
-		BUG();
-		goto out;
-	}
-
 	/* Some actions do not requires the mutex */
 	switch (cmd) {
 	case GET_ARRAY_INFO: