From: Markus Armbruster Date: Wed, 10 Jun 2020 05:31:51 +0000 (+0200) Subject: Revert "hw/prep: realize the PCI root bus as part of the prep init" X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9e1b990c2ee6e1b14f9abdf5ab325ff2cf9d8bd5;p=qemu.git Revert "hw/prep: realize the PCI root bus as part of the prep init" This reverts commit 685f9a3428f625f580af0123aa95f4838d86cac3. Realizing a device automatically realizes its buses, in device_set_realized(). Realizing them in realize methods is redundant, unless the methods themselves require them to be realized early. raven_pcihost_realizefn() doesn't. Drop the redundant bus realization. Cc: Marcel Apfelbaum Cc: Michael S. Tsirkin Signed-off-by: Markus Armbruster Reviewed-by: Paolo Bonzini Message-Id: <20200610053247.1583243-3-armbru@redhat.com> --- diff --git a/hw/pci-host/prep.c b/hw/pci-host/prep.c index 88e2fc66a9..fc01a294a4 100644 --- a/hw/pci-host/prep.c +++ b/hw/pci-host/prep.c @@ -268,7 +268,6 @@ static void raven_pcihost_realizefn(DeviceState *d, Error **errp) memory_region_add_subregion(address_space_mem, 0xbffffff0, &s->pci_intack); /* TODO Remove once realize propagates to child devices. */ - object_property_set_bool(OBJECT(&s->pci_bus), true, "realized", errp); object_property_set_bool(OBJECT(&s->pci_dev), true, "realized", errp); }