From: Kevin Wolf <kwolf@redhat.com>
Date: Tue, 26 Mar 2013 16:49:55 +0000 (+0100)
Subject: qcow2: Remove bogus unlock of s->lock
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9ee6439e27d15c528fde6d9da1e4c238a23b6b7a;p=qemu.git

qcow2: Remove bogus unlock of s->lock

The unlock wakes up the next coroutine, but the currently running
coroutine will lock it again before it yields, so this doesn't make a
lot of sense.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
---

diff --git a/block/qcow2.c b/block/qcow2.c
index 8ea696a1aa..3f7edf5652 100644
--- a/block/qcow2.c
+++ b/block/qcow2.c
@@ -869,9 +869,7 @@ static coroutine_fn int qcow2_co_writev(BlockDriverState *bs,
                 QLIST_REMOVE(l2meta, next_in_flight);
             }
 
-            qemu_co_mutex_unlock(&s->lock);
             qemu_co_queue_restart_all(&l2meta->dependent_requests);
-            qemu_co_mutex_lock(&s->lock);
 
             g_free(l2meta);
             l2meta = NULL;