From: Aditya Pakki Date: Tue, 17 Dec 2019 19:44:37 +0000 (-0600) Subject: RDMA/srpt: Remove unnecessary assertion in srpt_queue_response X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9f48db0d4a08624bb9ba847ea40c8abad753b396;p=linux.git RDMA/srpt: Remove unnecessary assertion in srpt_queue_response Since ch has already been de-referenced by the time we get to the BUG_ON, it is useless. The back trace alone is enough to tell what is going on, delete the redundant BUG_ON. Link: https://lore.kernel.org/r/20191217194437.25568-1-pakki001@umn.edu Signed-off-by: Aditya Pakki Reviewed-by: Bart Van Assche Reviewed-by: Jason Gunthorpe Signed-off-by: Jason Gunthorpe --- diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c index 23c782e3d49a6..98552749d71cb 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -2810,8 +2810,6 @@ static void srpt_queue_response(struct se_cmd *cmd) int resp_len, ret, i; u8 srp_tm_status; - BUG_ON(!ch); - state = ioctx->state; switch (state) { case SRPT_STATE_NEW: