From: Josef Bacik Date: Fri, 28 Sep 2018 17:45:40 +0000 (-0400) Subject: blk-iolatency: deal with nr_requests == 1 X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=9f60511a021e677c43b3e2d1a890e3d0d372e394;p=linux.git blk-iolatency: deal with nr_requests == 1 Hitting the case where blk_queue_depth() returned 1 uncovered the fact that iolatency doesn't actually handle this case properly, it simply doesn't scale down anybody. For this case we should go straight into applying the time delay, which we weren't doing. Since we already limit the floor at 1 request this if statement is not needed, and this allows us to set our depth to 1 which allows us to apply the delay if needed. Signed-off-by: Josef Bacik Signed-off-by: Jens Axboe --- diff --git a/block/blk-iolatency.c b/block/blk-iolatency.c index c2e38bc12f270..8daea7a4fe492 100644 --- a/block/blk-iolatency.c +++ b/block/blk-iolatency.c @@ -312,7 +312,7 @@ static void scale_change(struct iolatency_grp *iolat, bool up) iolat->rq_depth.max_depth = old; wake_up_all(&iolat->rq_wait.wait); } - } else if (old > 1) { + } else { old >>= 1; iolat->rq_depth.max_depth = max(old, 1UL); }