From: Alex Deucher Date: Fri, 25 Sep 2020 14:29:01 +0000 (-0400) Subject: drm/amdgpu: fix a warning in amdgpu_ras.c (v2) X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a069a9eb73f896b84d8cfda2f2d436c1844c4e92;p=linux.git drm/amdgpu: fix a warning in amdgpu_ras.c (v2) drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’: drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value of ‘sysfs_create_group’, declared with attribute warn_unused_result [-Wunused-result] 1284 | sysfs_create_group(&adev->dev->kobj, &group); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ v2: just print an error for sysfs group creation failure Acked-by: Nirmoy Das Reviewed-by: Luben Tuikov Signed-off-by: Alex Deucher --- diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c index 49d10330bf645..8bf6a7c056bc1 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c @@ -1266,6 +1266,7 @@ static int amdgpu_ras_fs_init(struct amdgpu_device *adev) NULL, NULL, }; + int r; /* add features entry */ con->features_attr = dev_attr_features; @@ -1281,7 +1282,9 @@ static int amdgpu_ras_fs_init(struct amdgpu_device *adev) sysfs_bin_attr_init(bin_attrs[0]); } - sysfs_create_group(&adev->dev->kobj, &group); + r = sysfs_create_group(&adev->dev->kobj, &group); + if (r) + dev_err(adev->dev, "Failed to create RAS sysfs group!"); return 0; }