From: Dan Carpenter <dan.carpenter@linaro.org>
Date: Sat, 4 May 2024 11:25:43 +0000 (+0300)
Subject: Bluetooth: qca: Fix error code in qca_read_fw_build_info()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a189f0ee6685457528db7a36ded3085e5d13ddc3;p=linux.git

Bluetooth: qca: Fix error code in qca_read_fw_build_info()

Return -ENOMEM on allocation failure.  Don't return success.

Fixes: cda0d6a198e2 ("Bluetooth: qca: fix info leak when fetching fw build id")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Johan Hovold <johan+linaro@kernel.org>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---

diff --git a/drivers/bluetooth/btqca.c b/drivers/bluetooth/btqca.c
index 6aefc922a08a4..dfbbac92242a8 100644
--- a/drivers/bluetooth/btqca.c
+++ b/drivers/bluetooth/btqca.c
@@ -136,8 +136,10 @@ static int qca_read_fw_build_info(struct hci_dev *hdev)
 	}
 
 	build_label = kstrndup(&edl->data[1], build_lbl_len, GFP_KERNEL);
-	if (!build_label)
+	if (!build_label) {
+		err = -ENOMEM;
 		goto out;
+	}
 
 	hci_set_fw_info(hdev, "%s", build_label);