From: Sumera Priyadarsini <sylphrenadin@gmail.com>
Date: Sun, 13 Sep 2020 12:05:48 +0000 (+0530)
Subject: scripts: coccicheck: Improve error feedback when coccicheck fails
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a19d1358345e040af9164ee7dd0f39ea0a99d565;p=linux.git

scripts: coccicheck: Improve error feedback when coccicheck fails

Currently, coccicheck fails with only the message "coccicheck failed"
and the error code for the failure. To obtain the error logs,
one needs to specify a debug file using the DEBUG_FILE option.

Modify coccicheck to display error logs when it crashes unless
DEBUG_FILE is set, in which case, the error logs are stored in
the specified debug file.

Signed-off-by: Sumera Priyadarsini <sylphrenadin@gmail.com>
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
---

diff --git a/scripts/coccicheck b/scripts/coccicheck
index 6e37cf36caae7..85136f4fe9706 100755
--- a/scripts/coccicheck
+++ b/scripts/coccicheck
@@ -126,8 +126,14 @@ run_cmd_parmap() {
 	if [ $VERBOSE -ne 0 ] ; then
 		echo "Running ($NPROC in parallel): $@"
 	fi
-	echo $@ >>$DEBUG_FILE
-	$@ 2>>$DEBUG_FILE
+	if [ "$DEBUG_FILE" != "/dev/null" -a "$DEBUG_FILE" != "" ]; then
+                echo $@>>$DEBUG_FILE
+                $@ 2>>$DEBUG_FILE
+        else
+                echo $@
+                $@ 2>&1
+	fi
+
 	err=$?
 	if [[ $err -ne 0 ]]; then
 		echo "coccicheck failed"