From: Oleg Nesterov <oleg@redhat.com>
Date: Fri, 2 Feb 2024 13:12:55 +0000 (+0100)
Subject: pid: kill the obsolete PIDTYPE_PID code in transfer_pid()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a1c6d5439fbddd06aad3ddbb7f12df0b98354070;p=linux.git

pid: kill the obsolete PIDTYPE_PID code in transfer_pid()

transfer_pid() must be never called with pid == PIDTYPE_PID,
new_leader->thread_pid should be changed by exchange_tids().

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Link: https://lore.kernel.org/r/20240202131255.GA26025@redhat.com
Signed-off-by: Christian Brauner <brauner@kernel.org>
---

diff --git a/kernel/pid.c b/kernel/pid.c
index 62461c7c82b8b..de0bf2f8d18bf 100644
--- a/kernel/pid.c
+++ b/kernel/pid.c
@@ -396,8 +396,7 @@ void exchange_tids(struct task_struct *left, struct task_struct *right)
 void transfer_pid(struct task_struct *old, struct task_struct *new,
 			   enum pid_type type)
 {
-	if (type == PIDTYPE_PID)
-		new->thread_pid = old->thread_pid;
+	WARN_ON_ONCE(type == PIDTYPE_PID);
 	hlist_replace_rcu(&old->pid_links[type], &new->pid_links[type]);
 }