From: Ashijeet Acharya <ashijeetacharya@gmail.com>
Date: Wed, 2 Nov 2016 10:40:03 +0000 (+0530)
Subject: block/nbd: Fix the leaked visitor
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a1d4e38a8b01a6699355c31867d524f8d4cd480e;p=qemu.git

block/nbd: Fix the leaked visitor

This patch frees the leaked visitor in nbd_refresh_filename() and uses
visit_free() to fix it. The leak was introduced by the commit 491d6c7.

Signed-off-by: Ashijeet Acharya <ashijeetacharya@gmail.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---

diff --git a/block/nbd.c b/block/nbd.c
index 9cff8396f9..35f24be069 100644
--- a/block/nbd.c
+++ b/block/nbd.c
@@ -536,6 +536,7 @@ static void nbd_refresh_filename(BlockDriverState *bs, QDict *options)
     ov = qobject_output_visitor_new(&saddr_qdict);
     visit_type_SocketAddress(ov, NULL, &s->saddr, &error_abort);
     visit_complete(ov, &saddr_qdict);
+    visit_free(ov);
     assert(qobject_type(saddr_qdict) == QTYPE_QDICT);
 
     qdict_put_obj(opts, "server", saddr_qdict);