From: Su Hui Date: Thu, 19 Oct 2023 08:33:52 +0000 (+0800) Subject: pds_core: add an error code check in pdsc_dl_info_get X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a1e4c334cbc9a80578c3784f8a3e7076bb19578d;p=linux.git pds_core: add an error code check in pdsc_dl_info_get check the value of 'ret' after call 'devlink_info_version_stored_put'. Signed-off-by: Su Hui Reviewed-by: Shannon Nelson Link: https://lore.kernel.org/r/20231019083351.1526484-1-suhui@nfschina.com Signed-off-by: Jakub Kicinski --- diff --git a/drivers/net/ethernet/amd/pds_core/devlink.c b/drivers/net/ethernet/amd/pds_core/devlink.c index 8b2b9e0d59f31..57f88c8b37def 100644 --- a/drivers/net/ethernet/amd/pds_core/devlink.c +++ b/drivers/net/ethernet/amd/pds_core/devlink.c @@ -124,6 +124,8 @@ int pdsc_dl_info_get(struct devlink *dl, struct devlink_info_req *req, snprintf(buf, sizeof(buf), "fw.slot_%d", i); err = devlink_info_version_stored_put(req, buf, fw_list.fw_names[i].fw_version); + if (err) + return err; } err = devlink_info_version_running_put(req,