From: Marek Behún <kabel@kernel.org>
Date: Sat, 26 Sep 2020 19:43:02 +0000 (+0200)
Subject: leds: tca6507: fix potential zero passed to ERR_PTR
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a238098251b690b7408f26d7c5b4c6ba44d7084c;p=linux.git

leds: tca6507: fix potential zero passed to ERR_PTR

Fix potential ERR_PTR(0).

Signed-off-by: Marek Behún <kabel@kernel.org>
Fixes: d78b10f5713d9 ("leds: tca6507: use fwnode API instead of OF")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Pavel Machek <pavel@ucw.cz>
---

diff --git a/drivers/leds/leds-tca6507.c b/drivers/leds/leds-tca6507.c
index 4b10ef9ae2212..d589c89930fdb 100644
--- a/drivers/leds/leds-tca6507.c
+++ b/drivers/leds/leds-tca6507.c
@@ -727,7 +727,7 @@ tca6507_led_dt_init(struct i2c_client *client)
 		ret = fwnode_property_read_u32(child, "reg", &reg);
 		if (ret || reg >= NUM_LEDS) {
 			fwnode_handle_put(child);
-			return ERR_PTR(ret);
+			return ERR_PTR(ret ? : -EINVAL);
 		}
 
 		tca_leds[reg] = led;