From: Pankaj Gupta Date: Wed, 11 Nov 2020 05:16:58 +0000 (+0100) Subject: md: use current request time as base for ktime comparisons X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a23f2aae8498d8c8bb6ff5301bda02db8093cb09;p=linux.git md: use current request time as base for ktime comparisons Request coalescing logic uses 'prev_flush_start' as base to compare the current request start time. 'prev_flush_start' is updated in other context. This patch changes this by using ktime comparison base to 'req_start' for better readability of code. Signed-off-by: Pankaj Gupta Signed-off-by: Song Liu --- diff --git a/drivers/md/md.c b/drivers/md/md.c index a0998ad6388cf..1a3a6150123e4 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -667,10 +667,10 @@ bool md_flush_request(struct mddev *mddev, struct bio *bio) */ wait_event_lock_irq(mddev->sb_wait, !mddev->flush_bio || - ktime_after(mddev->prev_flush_start, req_start), + ktime_before(req_start, mddev->prev_flush_start), mddev->lock); /* new request after previous flush is completed */ - if (!ktime_after(mddev->prev_flush_start, req_start)) { + if (ktime_after(req_start, mddev->prev_flush_start)) { WARN_ON(mddev->flush_bio); mddev->flush_bio = bio; bio = NULL;