From: Paul E. McKenney Date: Wed, 4 Jul 2018 00:22:34 +0000 (-0700) Subject: rcu: Remove rsp parameter from rcu_print_detail_task_stall() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a2887cd85f38cf2fdbf42bad97e5c412d99ff5ca;p=linux.git rcu: Remove rsp parameter from rcu_print_detail_task_stall() There now is only one rcu_state structure in a given build of the Linux kernel, so there is no need to pass it as a parameter to RCU's functions. This commit therefore removes the rsp parameter from rcu_print_detail_task_stall(). Signed-off-by: Paul E. McKenney --- diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c index 0b274530e8a85..130ce5eebdfa9 100644 --- a/kernel/rcu/tree.c +++ b/kernel/rcu/tree.c @@ -1360,7 +1360,7 @@ static void print_other_cpu_stall(unsigned long gp_seq) rcu_dump_cpu_stacks(); /* Complain about tasks blocking the grace period. */ - rcu_print_detail_task_stall(rsp); + rcu_print_detail_task_stall(); } else { if (rcu_seq_current(&rsp->gp_seq) != gp_seq) { pr_err("INFO: Stall ended before state dump start\n"); diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h index d60304f1ef560..00d268cb4d048 100644 --- a/kernel/rcu/tree.h +++ b/kernel/rcu/tree.h @@ -452,7 +452,7 @@ static int rcu_preempt_blocked_readers_cgp(struct rcu_node *rnp); #ifdef CONFIG_HOTPLUG_CPU static bool rcu_preempt_has_tasks(struct rcu_node *rnp); #endif /* #ifdef CONFIG_HOTPLUG_CPU */ -static void rcu_print_detail_task_stall(struct rcu_state *rsp); +static void rcu_print_detail_task_stall(void); static int rcu_print_task_stall(struct rcu_node *rnp); static int rcu_print_task_exp_stall(struct rcu_node *rnp); static void rcu_preempt_check_blocked_tasks(struct rcu_state *rsp, diff --git a/kernel/rcu/tree_plugin.h b/kernel/rcu/tree_plugin.h index c678c76a754e5..1d8148b0d4e57 100644 --- a/kernel/rcu/tree_plugin.h +++ b/kernel/rcu/tree_plugin.h @@ -683,12 +683,12 @@ static void rcu_print_detail_task_stall_rnp(struct rcu_node *rnp) * Dump detailed information for all tasks blocking the current RCU * grace period. */ -static void rcu_print_detail_task_stall(struct rcu_state *rsp) +static void rcu_print_detail_task_stall(void) { struct rcu_node *rnp = rcu_get_root(); rcu_print_detail_task_stall_rnp(rnp); - rcu_for_each_leaf_node(rsp, rnp) + rcu_for_each_leaf_node(&rcu_state, rnp) rcu_print_detail_task_stall_rnp(rnp); } @@ -1005,7 +1005,7 @@ static void rcu_preempt_deferred_qs(struct task_struct *t) { } * Because preemptible RCU does not exist, we never have to check for * tasks blocked within RCU read-side critical sections. */ -static void rcu_print_detail_task_stall(struct rcu_state *rsp) +static void rcu_print_detail_task_stall(void) { }