From: Daniel P. Berrangé <berrange@redhat.com>
Date: Thu, 4 Jan 2024 16:29:39 +0000 (+0000)
Subject: Revert "tests/qtest/netdev-socket: Raise connection timeout to 120 seconds"
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a298293866b277cb40ab24dcedda36c2b89ed2ab;p=qemu.git

Revert "tests/qtest/netdev-socket: Raise connection timeout to 120 seconds"

This reverts commit 0daaf2761f6d268ffaa2d01d450e202e127452b1.

The test was not timing out because of slow execution. It was
timing out due to a race condition leading to the client QEMU
attempting (and fatally failing) to connect before the server
QEMU was listening.

Signed-off-by: "Daniel P. Berrangé" <berrange@redhat.com>
Message-ID: <20240104162942.211458-4-berrange@redhat.com>
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
Signed-off-by: Thomas Huth <thuth@redhat.com>
---

diff --git a/tests/qtest/netdev-socket.c b/tests/qtest/netdev-socket.c
index 7ba1eff120..3fc2ac26d0 100644
--- a/tests/qtest/netdev-socket.c
+++ b/tests/qtest/netdev-socket.c
@@ -16,7 +16,7 @@
 #include "qapi/qobject-input-visitor.h"
 #include "qapi/qapi-visit-sockets.h"
 
-#define CONNECTION_TIMEOUT    120
+#define CONNECTION_TIMEOUT    60
 
 #define EXPECT_STATE(q, e, t)                             \
 do {                                                      \