From: Yu Kuai <yukuai3@huawei.com>
Date: Fri, 25 Aug 2023 03:09:55 +0000 (+0800)
Subject: md: don't check 'mddev->pers' from suspend_hi_store()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a2a9f16838509475ea6801f7794a89e03d55e3ed;p=linux.git

md: don't check 'mddev->pers' from suspend_hi_store()

Now that mddev_suspend() doean't rely on 'mddev->pers' to be set, it's
safe to remove such checking.

This will also allow the array to be suspended even before the array
is ran.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Song Liu <song@kernel.org>
Link: https://lore.kernel.org/r/20230825030956.1527023-7-yukuai1@huaweicloud.com
---

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 889c282a91eaa..081b6ec2da523 100644
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -5226,18 +5226,13 @@ suspend_hi_store(struct mddev *mddev, const char *buf, size_t len)
 	err = mddev_lock(mddev);
 	if (err)
 		return err;
-	err = -EINVAL;
-	if (mddev->pers == NULL)
-		goto unlock;
 
 	mddev_suspend(mddev);
 	mddev->suspend_hi = new;
 	mddev_resume(mddev);
 
-	err = 0;
-unlock:
 	mddev_unlock(mddev);
-	return err ?: len;
+	return len;
 }
 static struct md_sysfs_entry md_suspend_hi =
 __ATTR(suspend_hi, S_IRUGO|S_IWUSR, suspend_hi_show, suspend_hi_store);