From: Chris Wilson Date: Sun, 23 Feb 2020 17:37:46 +0000 (+0000) Subject: drm/i915/display: Fix inverted WARN_ON X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a2ab4ab6e9accfb3468445ad34a378d14282f87c;p=linux.git drm/i915/display: Fix inverted WARN_ON Restore the previous WARN_ON(cond) so that we don't complain about poor old Cherryview. Fixes: eb020ca3d43f ("drm/i915/display/dp: Make WARN* drm specific where drm_device ptr is available") Signed-off-by: Chris Wilson Cc: Pankaj Bharadiya Cc: Jani Nikula Reviewed-by: Jani Nikula Link: https://patchwork.freedesktop.org/patch/msgid/20200223173959.3885742-1-chris@chris-wilson.co.uk --- diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c index 2f93326c16a3e..e8bebd27004d8 100644 --- a/drivers/gpu/drm/i915/display/intel_dp.c +++ b/drivers/gpu/drm/i915/display/intel_dp.c @@ -1023,9 +1023,10 @@ void intel_power_sequencer_reset(struct drm_i915_private *dev_priv) { struct intel_encoder *encoder; - if (drm_WARN_ON(&dev_priv->drm, !IS_VALLEYVIEW(dev_priv) && - IS_CHERRYVIEW(dev_priv) && - !IS_GEN9_LP(dev_priv))) + if (drm_WARN_ON(&dev_priv->drm, + !(IS_VALLEYVIEW(dev_priv) || + IS_CHERRYVIEW(dev_priv) || + IS_GEN9_LP(dev_priv)))) return; /*