From: Pavel Begunkov Date: Sun, 25 Apr 2021 23:16:31 +0000 (+0100) Subject: io_uring: fix invalid error check after malloc X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a2b4198cab7e3edcb78fce77e0e8aca130435403;p=linux.git io_uring: fix invalid error check after malloc Now we allocate io_mapped_ubuf instead of bvec, so we clearly have to check its address after allocation. Fixes: 41edf1a5ec967 ("io_uring: keep table of pointers to ubufs") Reported-by: kernel test robot Signed-off-by: Pavel Begunkov Link: https://lore.kernel.org/r/d28eb1bc4384284f69dbce35b9f70c115ff6176f.1619392565.git.asml.silence@gmail.com Signed-off-by: Jens Axboe --- diff --git a/fs/io_uring.c b/fs/io_uring.c index eef373394ee9f..b65a25384019b 100644 --- a/fs/io_uring.c +++ b/fs/io_uring.c @@ -8265,7 +8265,7 @@ static int io_sqe_buffer_register(struct io_ring_ctx *ctx, struct iovec *iov, goto done; imu = kvmalloc(struct_size(imu, bvec, nr_pages), GFP_KERNEL); - if (!imu->bvec) + if (!imu) goto done; ret = 0;