From: Jason Xing Date: Mon, 4 Mar 2024 08:20:42 +0000 (+0800) Subject: netrom: Fix a data-race around sysctl_netrom_transport_requested_window_size X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a2e706841488f474c06e9b33f71afc947fb3bf56;p=linux.git netrom: Fix a data-race around sysctl_netrom_transport_requested_window_size We need to protect the reader reading the sysctl value because the value can be changed concurrently. Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2") Signed-off-by: Jason Xing Signed-off-by: Paolo Abeni --- diff --git a/net/netrom/af_netrom.c b/net/netrom/af_netrom.c index 10eee02ef99ed..e65418fb9d882 100644 --- a/net/netrom/af_netrom.c +++ b/net/netrom/af_netrom.c @@ -462,7 +462,7 @@ static int nr_create(struct net *net, struct socket *sock, int protocol, msecs_to_jiffies(READ_ONCE(sysctl_netrom_transport_busy_delay)); nr->idle = msecs_to_jiffies(sysctl_netrom_transport_no_activity_timeout); - nr->window = sysctl_netrom_transport_requested_window_size; + nr->window = READ_ONCE(sysctl_netrom_transport_requested_window_size); nr->bpqext = 1; nr->state = NR_STATE_0;