From: Fabio M. De Francesco Date: Fri, 24 Sep 2021 12:26:57 +0000 (+0200) Subject: staging: r8188eu: change the type of a variable in rtw_write16() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a3c1900154d0d164f9f4b507d22cce754243d6b6;p=linux.git staging: r8188eu: change the type of a variable in rtw_write16() Change the type of "data" from __le32 to __le16 in rtw_write16(). The argument "val", which is u16, after being conditionally swapped to little endian, is assigned to "data"; therefore, __le16 is the most suitable type for "data". Remove the bitwise AND of "val" with 0xffff because it is redundant. Use cpu_to_le16() because "data" is __le16. Co-developed-by: Pavel Skripkin Signed-off-by: Pavel Skripkin Signed-off-by: Fabio M. De Francesco Link: https://lore.kernel.org/r/20210924122705.3781-9-fmdefrancesco@gmail.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/r8188eu/hal/usb_ops_linux.c b/drivers/staging/r8188eu/hal/usb_ops_linux.c index 95cd7a6bc28bb..5dcab1ee4be0c 100644 --- a/drivers/staging/r8188eu/hal/usb_ops_linux.c +++ b/drivers/staging/r8188eu/hal/usb_ops_linux.c @@ -145,7 +145,7 @@ int rtw_write16(struct adapter *adapter, u32 addr, u16 val) struct io_priv *io_priv = &adapter->iopriv; struct intf_hdl *intf = &io_priv->intf; u16 value = addr & 0xffff; - __le32 data = cpu_to_le32(val & 0x0000ffff); + __le16 data = cpu_to_le16(val); int ret; ret = usbctrl_vendorreq(intf, value, &data, 2, REALTEK_USB_VENQT_WRITE);