From: Liu Xiang Date: Tue, 14 May 2019 00:16:22 +0000 (-0700) Subject: slub: remove useless kmem_cache_debug() before remove_full() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a4d3f8916c65b63e6b9457cdec74ceaaff7e6b12;p=linux.git slub: remove useless kmem_cache_debug() before remove_full() When CONFIG_SLUB_DEBUG is not enabled, remove_full() is empty. While CONFIG_SLUB_DEBUG is enabled, remove_full() can check s->flags by itself. So kmem_cache_debug() is useless and can be removed. Link: http://lkml.kernel.org/r/1552577313-2830-1-git-send-email-liu.xiang6@zte.com.cn Signed-off-by: Liu Xiang Acked-by: David Rientjes Cc: Christoph Lameter Cc: Pekka Enberg Cc: Joonsoo Kim Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/mm/slub.c b/mm/slub.c index ce6917b7451d2..af3b72b5de826 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2903,8 +2903,7 @@ static void __slab_free(struct kmem_cache *s, struct page *page, * then add it. */ if (!kmem_cache_has_cpu_partial(s) && unlikely(!prior)) { - if (kmem_cache_debug(s)) - remove_full(s, n, page); + remove_full(s, n, page); add_partial(n, page, DEACTIVATE_TO_TAIL); stat(s, FREE_ADD_PARTIAL); }