From: Stefan Hajnoczi Date: Wed, 17 Jun 2020 13:21:59 +0000 (+0100) Subject: block/nvme: clarify that free_req_queue is protected by q->lock X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a5db74f324ee55badfa61b03922ec24439bb94a6;p=qemu.git block/nvme: clarify that free_req_queue is protected by q->lock Existing users access free_req_queue under q->lock. Document this. Signed-off-by: Stefan Hajnoczi Reviewed-by: Sergio Lopez Reviewed-by: Philippe Mathieu-Daudé Message-id: 20200617132201.1832152-6-stefanha@redhat.com Signed-off-by: Stefan Hajnoczi --- diff --git a/block/nvme.c b/block/nvme.c index 8e60882af3..426c77e5ab 100644 --- a/block/nvme.c +++ b/block/nvme.c @@ -57,7 +57,6 @@ typedef struct { } NVMeRequest; typedef struct { - CoQueue free_req_queue; QemuMutex lock; /* Fields protected by BQL */ @@ -65,6 +64,7 @@ typedef struct { uint8_t *prp_list_pages; /* Fields protected by @lock */ + CoQueue free_req_queue; NVMeQueue sq, cq; int cq_phase; int free_req_head;