From: Srinivas Neeli Date: Mon, 14 Sep 2020 08:49:57 +0000 (+0200) Subject: can: xilinx_can: Check return value of set_reset_mode X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a61035c5a84bc92bffa4b252d1bc97034724667c;p=linux.git can: xilinx_can: Check return value of set_reset_mode Check return value of set_reset_mode() for error. Addresses-Coverity: "check_return" Signed-off-by: Srinivas Neeli Signed-off-by: Michal Simek Link: https://lore.kernel.org/r/bac2c2b857986472a11db341b3f6f7a8905ad0dd.1600073396.git.michal.simek@xilinx.com Signed-off-by: Marc Kleine-Budde --- diff --git a/drivers/net/can/xilinx_can.c b/drivers/net/can/xilinx_can.c index d3c41e6c275d2..9ea6ad73b07d8 100644 --- a/drivers/net/can/xilinx_can.c +++ b/drivers/net/can/xilinx_can.c @@ -1369,9 +1369,13 @@ static irqreturn_t xcan_interrupt(int irq, void *dev_id) static void xcan_chip_stop(struct net_device *ndev) { struct xcan_priv *priv = netdev_priv(ndev); + int ret; /* Disable interrupts and leave the can in configuration mode */ - set_reset_mode(ndev); + ret = set_reset_mode(ndev); + if (ret < 0) + netdev_dbg(ndev, "set_reset_mode() Failed\n"); + priv->can.state = CAN_STATE_STOPPED; }