From: Christian Lamparter Date: Thu, 8 Jun 2023 15:36:27 +0000 (+0200) Subject: ARM: dts: BCM5301X: MR26: MR32: remove bogus nand-ecc-algo property X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a6a1a156f5debaebf9f61850d111b966e9be9ee9;p=linux.git ARM: dts: BCM5301X: MR26: MR32: remove bogus nand-ecc-algo property | bcm53015-meraki-mr26.dtb: nand-controller@18028000: | nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs'] | From schema: Documentation/[...]/nand-controller.yaml | bcm53016-meraki-mr32.dtb: nand-controller@18028000: | nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs'] | From schema: Documentation/[...]/nand-controller.yaml original ECC values for these old Merakis are sadly not provided by the vendor. It looks like Meraki just stuck with what Broadcom's SDK was doing... which left this up to the proprietary nand driver. Note: The invalid setting was and is handled by brcmnand. It falls back to "bch" in brcmnand_setup_dev() when ecc.algo is set to NAND_ECC_ALGO_UNKNOWN (since "hw" is not in the list above). A correct nand-ecc-algo = "bch"; is already specified in the included "bcm5301x-nand-cs0-bch8.dtsi". So this line can be dropped. Reported-by: Rafał Miłecki (per Mail) Fixes: 935327a73553 ("ARM: dts: BCM5301X: Add DT for Meraki MR26") Fixes: ec88a9c344d9 ("ARM: BCM5301X: Add DT for Meraki MR32") Signed-off-by: Christian Lamparter Link: https://lore.kernel.org/r/2c4d00dd40124c2ddc0b139cbce7531b108f9052.1686238550.git.chunkeey@gmail.com Signed-off-by: Florian Fainelli --- diff --git a/arch/arm/boot/dts/bcm53015-meraki-mr26.dts b/arch/arm/boot/dts/bcm53015-meraki-mr26.dts index 24ba467c67b91..c36d3231183bd 100644 --- a/arch/arm/boot/dts/bcm53015-meraki-mr26.dts +++ b/arch/arm/boot/dts/bcm53015-meraki-mr26.dts @@ -72,8 +72,6 @@ }; &nandcs { - nand-ecc-algo = "hw"; - partitions { compatible = "fixed-partitions"; #address-cells = <0x1>; diff --git a/arch/arm/boot/dts/bcm53016-meraki-mr32.dts b/arch/arm/boot/dts/bcm53016-meraki-mr32.dts index 559d6c371d67a..e6156fa5cb3db 100644 --- a/arch/arm/boot/dts/bcm53016-meraki-mr32.dts +++ b/arch/arm/boot/dts/bcm53016-meraki-mr32.dts @@ -125,8 +125,6 @@ }; &nandcs { - nand-ecc-algo = "hw"; - partitions { /* * The partition autodetection does not work for this device.