From: Tom Rix Date: Tue, 4 Apr 2023 17:21:48 +0000 (+0100) Subject: nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout storage-class-specifier to... X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a8642cd11635a35a5f1dc31857887900d6610778;p=linux.git nvmem: layouts: sl28vpd: set varaiable sl28vpd_layout storage-class-specifier to static smatch reports drivers/nvmem/layouts/sl28vpd.c:144:21: warning: symbol 'sl28vpd_layout' was not declared. Should it be static? This variable is only used in one file so it should be static. Signed-off-by: Tom Rix Signed-off-by: Srinivas Kandagatla Link: https://lore.kernel.org/r/20230404172148.82422-41-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/nvmem/layouts/sl28vpd.c b/drivers/nvmem/layouts/sl28vpd.c index 9cc1715c2fd51..05671371f6316 100644 --- a/drivers/nvmem/layouts/sl28vpd.c +++ b/drivers/nvmem/layouts/sl28vpd.c @@ -141,7 +141,7 @@ static const struct of_device_id sl28vpd_of_match_table[] = { }; MODULE_DEVICE_TABLE(of, sl28vpd_of_match_table); -struct nvmem_layout sl28vpd_layout = { +static struct nvmem_layout sl28vpd_layout = { .name = "sl28-vpd", .of_match_table = sl28vpd_of_match_table, .add_cells = sl28vpd_add_cells,