From: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date: Sun, 18 Nov 2012 22:59:47 +0000 (-0800)
Subject: max17042_battery: Fix missing verify_model_lock() return value check
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a879f19fe7decb9a53d13a63edd2eced8c2895a2;p=linux.git

max17042_battery: Fix missing verify_model_lock() return value check

The second error check is unreachable because the lock function isn't
assigned to ret.

Signed-off-by: Alan Cox <alan@linux.intel.com>
Acked-by: Ramakrishna Pallala <ramakrishna.pallala@intel.com>
Signed-off-by: Anton Vorontsov <anton.vorontsov@linaro.org>
---

diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
index 74abc6c755b49..66b2c7b509149 100644
--- a/drivers/power/max17042_battery.c
+++ b/drivers/power/max17042_battery.c
@@ -572,7 +572,8 @@ static int max17042_init_chip(struct max17042_chip *chip)
 			__func__);
 		return -EIO;
 	}
-	max17042_verify_model_lock(chip);
+
+	ret = max17042_verify_model_lock(chip);
 	if (ret) {
 		dev_err(&chip->client->dev, "%s lock verify failed\n",
 			__func__);