From: Al Viro <viro@zeniv.linux.org.uk>
Date: Tue, 15 May 2018 01:26:32 +0000 (-0400)
Subject: cifs_lookup(): cifs_get_inode_...() never returns 0 with *inode left NULL
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a8b75f663ee825ab9d75839482bb12198faee70d;p=linux.git

cifs_lookup(): cifs_get_inode_...() never returns 0 with *inode left NULL

not since 2004...

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
---

diff --git a/fs/cifs/dir.c b/fs/cifs/dir.c
index 81ba6e0d88d8f..ecbf36c459eae 100644
--- a/fs/cifs/dir.c
+++ b/fs/cifs/dir.c
@@ -812,7 +812,7 @@ cifs_lookup(struct inode *parent_dir_inode, struct dentry *direntry,
 				parent_dir_inode->i_sb, xid, NULL);
 	}
 
-	if ((rc == 0) && (newInode != NULL)) {
+	if (rc == 0) {
 		d_add(direntry, newInode);
 		/* since paths are not looked up by component - the parent
 		   directories are presumed to be good here */