From: Martin Kaiser Date: Sun, 3 Apr 2022 16:54:36 +0000 (+0200) Subject: staging: r8188eu: remove psa, pda X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a9207f5e5101272c8bfd5e1aee6494be48f7c878;p=linux.git staging: r8188eu: remove psa, pda Remove the psa, pda variables. They are set and read only once. We can use the ieee80211 helpers directly. Signed-off-by: Martin Kaiser Link: https://lore.kernel.org/r/20220403165438.357728-10-martin@kaiser.cx Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/r8188eu/core/rtw_recv.c b/drivers/staging/r8188eu/core/rtw_recv.c index 75c0e0b171855..63ce66489146c 100644 --- a/drivers/staging/r8188eu/core/rtw_recv.c +++ b/drivers/staging/r8188eu/core/rtw_recv.c @@ -937,7 +937,7 @@ static int validate_recv_data_frame(struct adapter *adapter, struct recv_frame *precv_frame) { u8 bretry; - u8 *psa, *pda, *pbssid; + u8 *pbssid; struct sta_info *psta = NULL; u8 *ptr = precv_frame->rx_data; struct ieee80211_hdr *hdr = (struct ieee80211_hdr *)precv_frame->rx_data; @@ -946,15 +946,13 @@ static int validate_recv_data_frame(struct adapter *adapter, int ret; bretry = ieee80211_has_retry(hdr->frame_control); - pda = ieee80211_get_DA(hdr); - psa = ieee80211_get_SA(hdr); pbssid = get_hdr_bssid(ptr); if (!pbssid) return _FAIL; - memcpy(pattrib->dst, pda, ETH_ALEN); - memcpy(pattrib->src, psa, ETH_ALEN); + memcpy(pattrib->dst, ieee80211_get_DA(hdr), ETH_ALEN); + memcpy(pattrib->src, ieee80211_get_SA(hdr), ETH_ALEN); memcpy(pattrib->bssid, pbssid, ETH_ALEN);