From: Bodong Wang Date: Thu, 17 Oct 2019 19:55:52 +0000 (-0500) Subject: net/mlx5: E-Switch, Remove redundant warning when QoS enable failed X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=a9814d7fde59332d54b244d55a7322b272a27430;p=linux.git net/mlx5: E-Switch, Remove redundant warning when QoS enable failed esw_vport_enable_qos can return error in cases below: 1. QoS is already enabled. Warnning is useless in this case. 2. Create scheduling element cmd failed. There is already a warning. Remove the redundant warnning if esw_vport_enable_qos returns err. Signed-off-by: Bodong Wang Reviewed-by: Parav Pandit Signed-off-by: Saeed Mahameed --- diff --git a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c index b4b93d2322a98..deeedf211af06 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/eswitch.c @@ -1801,9 +1801,7 @@ static int esw_enable_vport(struct mlx5_eswitch *esw, struct mlx5_vport *vport, goto done; /* Attach vport to the eswitch rate limiter */ - if (esw_vport_enable_qos(esw, vport, vport->info.max_rate, - vport->qos.bw_share)) - esw_warn(esw->dev, "Failed to attach vport %d to eswitch rate limiter", vport_num); + esw_vport_enable_qos(esw, vport, vport->info.max_rate, vport->qos.bw_share); /* Sync with current vport context */ vport->enabled_events = enabled_events;