From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Mon, 6 Aug 2018 02:22:37 +0000 (+1000)
Subject: fsi: scom: Fix NULL dereference
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=aa1221b2584f06066d1e6b22ef7950fb12d94864;p=linux.git

fsi: scom: Fix NULL dereference

The chardev conversion forgot to copy the fsi_dev,
silly mistake, compounded by a testing mistake on
my side, this specific driver wasn't being tested
properly.

Fixes: d8f4587655f9 "fsi: scom: Convert to use the new chardev"
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

diff --git a/drivers/fsi/fsi-scom.c b/drivers/fsi/fsi-scom.c
index 0f303a700f69d..df94021dd9d12 100644
--- a/drivers/fsi/fsi-scom.c
+++ b/drivers/fsi/fsi-scom.c
@@ -598,6 +598,7 @@ static int scom_probe(struct device *dev)
 		kfree(scom);
 		return -ENODEV;
 	}
+	scom->fsi_dev = fsi_dev;
 
 	/* Create chardev for userspace access */
 	scom->dev.type = &fsi_cdev_type;