From: Nícolas F. R. A. Prado Date: Fri, 8 Jul 2022 19:26:05 +0000 (-0400) Subject: Revert "dt-bindings: usb: mtk-xhci: Make all clocks required" X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=aae7948d564c614c26eb896eb8be57879146240c;p=linux.git Revert "dt-bindings: usb: mtk-xhci: Make all clocks required" This reverts commit ebc4969ae125e65fdb563f66f4bfa7aec95f7eb4. That commit was supposed to make the binding better reflect the MediaTek XHCI hardware block by requiring all clocks to be present. But doing that also causes too much noise in the devicetrees, since it requires updating old MediaTek DTs to add clock handles for the fixed clocks, and going forward every new clock added to the binding would require even more updates. The commit also didn't update the example to match the changes, causing additional warnings. Instead let's keep the clocks optional so that old devicetrees can keep omitting the fixed clocks, and we'll just add the clocks as required on new DTs. Fixes: ebc4969ae125 ("dt-bindings: usb: mtk-xhci: Make all clocks required") Reviewed-by: AngeloGioacchino Del Regno Reviewed-by: Chunfeng Yun Acked-by: Rob Herring Signed-off-by: Nícolas F. R. A. Prado Link: https://lore.kernel.org/r/20220708192605.43351-1-nfraprado@collabora.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml index 04cbbca0e94ee..b0e58b15b9ae7 100644 --- a/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml +++ b/Documentation/devicetree/bindings/usb/mediatek,mtk-xhci.yaml @@ -68,6 +68,7 @@ properties: maxItems: 1 clocks: + minItems: 1 items: - description: Controller clock used by normal mode - description: Reference clock used by low power mode etc @@ -76,8 +77,9 @@ properties: - description: controller clock clock-names: + minItems: 1 items: - - const: sys_ck + - const: sys_ck # required, the following ones are optional - const: ref_ck - const: mcu_ck - const: dma_ck