From: Markus Armbruster Date: Tue, 10 Jul 2012 09:12:54 +0000 (+0200) Subject: blockdev: Drop redundant CHS validation for if=ide X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=aaea3f366eeb8c5c23d821cdd1ce078086fe3764;p=qemu.git blockdev: Drop redundant CHS validation for if=ide Leave it to ide_init_drive(). Signed-off-by: Markus Armbruster Signed-off-by: Kevin Wolf --- diff --git a/blockdev.c b/blockdev.c index 06c997e864..5f8677ef05 100644 --- a/blockdev.c +++ b/blockdev.c @@ -330,15 +330,15 @@ DriveInfo *drive_init(QemuOpts *opts, int default_to_scsi) max_devs = if_max_devs[type]; if (cyls || heads || secs) { - if (cyls < 1 || (type == IF_IDE && cyls > 16383)) { + if (cyls < 1) { error_report("invalid physical cyls number"); return NULL; } - if (heads < 1 || (type == IF_IDE && heads > 16)) { + if (heads < 1) { error_report("invalid physical heads number"); return NULL; } - if (secs < 1 || (type == IF_IDE && secs > 63)) { + if (secs < 1) { error_report("invalid physical secs number"); return NULL; }