From: Sakari Ailus Date: Thu, 7 Dec 2023 10:00:02 +0000 (+0200) Subject: media: v4l: Safely to call v4l2_subdev_cleanup on an uninitialised subdev X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ab8d7194acd1fea1702fff41a1ec93e458b6dcbf;p=linux.git media: v4l: Safely to call v4l2_subdev_cleanup on an uninitialised subdev Graciously handle an uninitialised (but still zeroed) sub-device in v4l2_subdev_cleanup(). The list_empty() check there is unnecessary, too, so replace that by cheking whether the lists's next field is NULL. Signed-off-by: Sakari Ailus Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/v4l2-core/v4l2-subdev.c b/drivers/media/v4l2-core/v4l2-subdev.c index 4fbefe4cd714d..1fa1acfa5b7bc 100644 --- a/drivers/media/v4l2-core/v4l2-subdev.c +++ b/drivers/media/v4l2-core/v4l2-subdev.c @@ -1521,7 +1521,8 @@ void v4l2_subdev_cleanup(struct v4l2_subdev *sd) __v4l2_subdev_state_free(sd->active_state); sd->active_state = NULL; - if (list_empty(&sd->async_subdev_endpoint_list)) + /* Uninitialised sub-device, bail out here. */ + if (!sd->async_subdev_endpoint_list.next) return; list_for_each_entry_safe(ase, ase_tmp, &sd->async_subdev_endpoint_list,