From: Stefan Hajnoczi <stefanha@redhat.com>
Date: Wed, 19 Mar 2014 07:58:57 +0000 (+0100)
Subject: virtio-rng: Avoid default_backend refcount leak
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=abdffd1fb78c1b98bda925d3d59123beca6761a3;p=qemu.git

virtio-rng: Avoid default_backend refcount leak

QOM child properties take a reference to the object and release it when
the property is deleted.  Therefore we should unref the default_backend
after we have added it as a child property.

Cc: KONRAD Frederic <fred.konrad@greensocs.com>
Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---

diff --git a/hw/virtio/virtio-rng.c b/hw/virtio/virtio-rng.c
index cbf01389a2..b6ab3610cb 100644
--- a/hw/virtio/virtio-rng.c
+++ b/hw/virtio/virtio-rng.c
@@ -162,6 +162,9 @@ static void virtio_rng_device_realize(DeviceState *dev, Error **errp)
                                   OBJECT(vrng->conf.default_backend),
                                   NULL);
 
+        /* The child property took a reference, we can safely drop ours now */
+        object_unref(OBJECT(vrng->conf.default_backend));
+
         object_property_set_link(OBJECT(dev),
                                  OBJECT(vrng->conf.default_backend),
                                  "rng", NULL);