From: John Snow Date: Fri, 20 Mar 2015 00:24:15 +0000 (-0400) Subject: ahci: Fix sglist offset manipulation for BE machines X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ac38123609742ce3fbdf53774a797ac230cbf118;p=qemu.git ahci: Fix sglist offset manipulation for BE machines This does not bother DMA, because DMA generally transfers the entire SGList in one shot if it can. PIO, on the other hand, tries to transfer just one sector at a time, and will make multiple visits to the sglist to fetch memory addresses. Fix the memory address calculaton when we have an offset by moving the offset addition OUTSIDE of the le64_to_cpu calculation. Signed-off-by: John Snow Reviewed-by: Stefan Hajnoczi Tested-by: Andreas Färber Message-id: 1426811056-2202-4-git-send-email-jsnow@redhat.com --- diff --git a/hw/ide/ahci.c b/hw/ide/ahci.c index e1ae36f7cd..7a223bede7 100644 --- a/hw/ide/ahci.c +++ b/hw/ide/ahci.c @@ -799,7 +799,7 @@ static int ahci_populate_sglist(AHCIDevice *ad, QEMUSGList *sglist, qemu_sglist_init(sglist, qbus->parent, (sglist_alloc_hint - off_idx), ad->hba->as); - qemu_sglist_add(sglist, le64_to_cpu(tbl[off_idx].addr + off_pos), + qemu_sglist_add(sglist, le64_to_cpu(tbl[off_idx].addr) + off_pos, prdt_tbl_entry_size(&tbl[off_idx]) - off_pos); for (i = off_idx + 1; i < sglist_alloc_hint; i++) {