From: Takashi Iwai Date: Wed, 31 Aug 2022 13:00:21 +0000 (+0200) Subject: ALSA: usb-audio: Drop superfluous interface setup at parsing X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ac5e2fb425e1121ceef2b9d1b3ffccc195d55707;p=linux.git ALSA: usb-audio: Drop superfluous interface setup at parsing We reset each interface that is being parsed for each stream, but this is superfluous and even can lead to spurious errors. Since the interface is set up properly at opening the endpoint for each actual stream operation, let's drop the superfluous one. Link: https://lore.kernel.org/r/20220831130021.4762-1-tiwai@suse.de Signed-off-by: Takashi Iwai --- diff --git a/sound/usb/stream.c b/sound/usb/stream.c index ceb93d798182c..99578e9a8af07 100644 --- a/sound/usb/stream.c +++ b/sound/usb/stream.c @@ -1221,12 +1221,6 @@ static int __snd_usb_parse_audio_interface(struct snd_usb_audio *chip, if (err < 0) return err; } - - /* try to set the interface... */ - usb_set_interface(chip->dev, iface_no, 0); - snd_usb_init_pitch(chip, fp); - snd_usb_init_sample_rate(chip, fp, fp->rate_max); - usb_set_interface(chip->dev, iface_no, altno); } return 0; }