From: Paolo Bonzini <pbonzini@redhat.com>
Date: Mon, 25 Jan 2016 12:46:43 +0000 (+0100)
Subject: ipmi: do not take/drop iothread lock
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ac5e8acdaec7c3a97d460e76ea912fa8ea7a4570;p=qemu.git

ipmi: do not take/drop iothread lock

This is not necessary and actually causes a hang; it was probably copied
and pasted from KVM code, that is one of the very few places that run
outside iothread lock.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/hw/ipmi/ipmi.c b/hw/ipmi/ipmi.c
index dfab272f9e..6adec1e990 100644
--- a/hw/ipmi/ipmi.c
+++ b/hw/ipmi/ipmi.c
@@ -51,9 +51,7 @@ static int ipmi_do_hw_op(IPMIInterface *s, enum ipmi_op op, int checkonly)
         if (checkonly) {
             return 0;
         }
-        qemu_mutex_lock_iothread();
         qmp_inject_nmi(NULL);
-        qemu_mutex_unlock_iothread();
         return 0;
 
     case IPMI_POWERCYCLE_CHASSIS: