From: Hanna Hawa Date: Tue, 24 Jul 2018 13:40:30 +0000 (+0300) Subject: dmaengine: mv_xor_v2: use {lower,upper}_32_bits to configure HW descriptor address X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ac7b06ba3125d54e2104545c302cb9894eff166d;p=linux.git dmaengine: mv_xor_v2: use {lower,upper}_32_bits to configure HW descriptor address >> drivers/dma/mv_xor_v2.c:647:36: sparse: constant 0xFFFF00000000 is so big it is long include/linux/device.h:678:13: sparse: undefined identifier '__builtin_mul_overflow' include/linux/device.h:678:13: sparse: call with no type! Use lower_32_bits and upper_32_bits to set the hw_desq address, instead of using constant. Signed-off-by: Hanna Hawa Reported-by: kbuild test robot Signed-off-by: Vinod Koul --- diff --git a/drivers/dma/mv_xor_v2.c b/drivers/dma/mv_xor_v2.c index d41d916f40fac..8dc0aa4d73ab8 100644 --- a/drivers/dma/mv_xor_v2.c +++ b/drivers/dma/mv_xor_v2.c @@ -642,9 +642,9 @@ static int mv_xor_v2_descq_init(struct mv_xor_v2_device *xor_dev) xor_dev->dma_base + MV_XOR_V2_DMA_DESQ_SIZE_OFF); /* write the DESQ address to the DMA enngine*/ - writel(xor_dev->hw_desq & 0xFFFFFFFF, + writel(lower_32_bits(xor_dev->hw_desq), xor_dev->dma_base + MV_XOR_V2_DMA_DESQ_BALR_OFF); - writel((xor_dev->hw_desq & 0xFFFF00000000) >> 32, + writel(upper_32_bits(xor_dev->hw_desq), xor_dev->dma_base + MV_XOR_V2_DMA_DESQ_BAHR_OFF); /*