From: Markus Armbruster <armbru@redhat.com>
Date: Fri, 13 Nov 2020 08:26:23 +0000 (+0100)
Subject: qga: Replace an unreachable error by abort()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ac84b0fa2857383ca25e86970fb12a067e56f66c;p=qemu.git

qga: Replace an unreachable error by abort()

check_suspend_mode()'s error message

    Parameter 'mode' expects GuestSuspendMode

makes no sense to users: GuestSuspendMode is a C enum.  Fortunately,
it is unreachable.  Replace it by abort().

Cc: Michael Roth <mdroth@linux.vnet.ibm.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20201113082626.2725812-8-armbru@redhat.com>
---

diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 300b87c859..87dc43e837 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -1441,8 +1441,7 @@ static void check_suspend_mode(GuestSuspendMode mode, Error **errp)
         }
         break;
     default:
-        error_setg(errp, QERR_INVALID_PARAMETER_VALUE, "mode",
-                   "GuestSuspendMode");
+        abort();
     }
 }