From: Xiongwei Song Date: Thu, 4 Apr 2024 05:58:24 +0000 (+0800) Subject: mm/slub: remove the check of !kmem_cache_has_cpu_partial() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=acc8f4dbf1b3293dc0b5a51eadde086123806c0f;p=linux.git mm/slub: remove the check of !kmem_cache_has_cpu_partial() The check of !kmem_cache_has_cpu_partial(s) with CONFIG_SLUB_CPU_PARTIAL enabled here is always false. We have already checked kmem_cache_debug() earlier and if it was true, then we either continued or broke from the loop so we can't reach this code in that case and don't need to check kmem_cache_debug() as part of kmem_cache_has_cpu_partial() again. Here we can remove it. Signed-off-by: Xiongwei Song Signed-off-by: Vlastimil Babka --- diff --git a/mm/slub.c b/mm/slub.c index f152b5df8ab2e..2e0351066c5d8 100644 --- a/mm/slub.c +++ b/mm/slub.c @@ -2610,8 +2610,7 @@ static struct slab *get_partial_node(struct kmem_cache *s, partial_slabs++; } #ifdef CONFIG_SLUB_CPU_PARTIAL - if (!kmem_cache_has_cpu_partial(s) - || partial_slabs > s->cpu_partial_slabs / 2) + if (partial_slabs > s->cpu_partial_slabs / 2) break; #else break;