From: David Hildenbrand Date: Mon, 11 Jan 2021 16:38:41 +0000 (+0100) Subject: s390x/tcg: Fix ALGSI X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ad11129b305b71ae835512554c59b83ca092251c;p=qemu.git s390x/tcg: Fix ALGSI Looks like something went wrong whiel touching that line. Instead of "r1" we need a new temporary. Also, we have to pass MO_TEQ, to indicate that we are working with 64-bit values. Let's revert these changes. Fixes: ff26d287bddc ("target/s390x: Improve cc computation for ADD LOGICAL") Reviewed-by: Richard Henderson Tested-by: Nick Desaulniers Tested-by: Guenter Roeck Signed-off-by: David Hildenbrand Message-Id: <20210111163845.18148-2-david@redhat.com> Signed-off-by: Cornelia Huck --- diff --git a/target/s390x/insn-data.def b/target/s390x/insn-data.def index 26badb663a..eac5136ee5 100644 --- a/target/s390x/insn-data.def +++ b/target/s390x/insn-data.def @@ -76,7 +76,7 @@ /* ADD LOGICAL WITH SIGNED IMMEDIATE */ D(0xeb6e, ALSI, SIY, GIE, la1, i2_32u, new, 0, asi, addu32, MO_TEUL) C(0xecda, ALHSIK, RIE_d, DO, r3_32u, i2_32u, new, r1_32, add, addu32) - C(0xeb7e, ALGSI, SIY, GIE, la1, i2, r1, 0, asiu64, addu64) + D(0xeb7e, ALGSI, SIY, GIE, la1, i2, new, 0, asiu64, addu64, MO_TEQ) C(0xecdb, ALGHSIK, RIE_d, DO, r3, i2, r1, 0, addu64, addu64) /* ADD LOGICAL WITH SIGNED IMMEDIATE HIGH */ C(0xcc0a, ALSIH, RIL_a, HW, r1_sr32, i2_32u, new, r1_32h, add, addu32)