From: Alexander Stein <alexander.stein@ew.tq-group.com>
Date: Tue, 2 May 2023 14:15:43 +0000 (+0200)
Subject: media: video-mux: Add missing media_entity_cleanup upon async register fail
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=ad5929547b545f6335f7a65cd5dd978967a02be3;p=linux.git

media: video-mux: Add missing media_entity_cleanup upon async register fail

Although media_entity_pads_init has been called, a call to
media_entity_cleanup in the cleanup code was missing.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---

diff --git a/drivers/media/platform/video-mux.c b/drivers/media/platform/video-mux.c
index 1d9f32e5a9171..b244873d593a9 100644
--- a/drivers/media/platform/video-mux.c
+++ b/drivers/media/platform/video-mux.c
@@ -474,6 +474,7 @@ static int video_mux_probe(struct platform_device *pdev)
 
 	ret = video_mux_async_register(vmux, num_pads - 1);
 	if (ret) {
+		media_entity_cleanup(&vmux->subdev.entity);
 		v4l2_async_nf_unregister(&vmux->notifier);
 		v4l2_async_nf_cleanup(&vmux->notifier);
 	}